Support resuming iteration from saved end_cursor. Implements #226 (WIP)#316
Open
tonycpsu wants to merge 2 commits intoalthonos:masterfrom
Open
Support resuming iteration from saved end_cursor. Implements #226 (WIP)#316tonycpsu wants to merge 2 commits intoalthonos:masterfrom
tonycpsu wants to merge 2 commits intoalthonos:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
===========================================
- Coverage 79.83% 51.04% -28.80%
===========================================
Files 16 26 +10
Lines 972 1538 +566
Branches 134 151 +17
===========================================
+ Hits 776 785 +9
- Misses 155 738 +583
+ Partials 41 15 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cursorargument to thepages()method to begin iteration using a storedend_cursorfrom a previous request.-c/--cursorcommand-line argument to support downloading beginning at a givenend_cursorvalue.The latter isn't particularly useful yet without a way to either display cursors in the downloader output or better yet save them to the cache directory, but it demonstrates the functionality.
This is a work in progress, but I figured I'd show what I have now to see if it merits merging with some additional documentation and polish.